make transform optional for DirectPosterior. #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janfb
force-pushed
the
transform-flag
branch
2 times, most recently
from
06aad3f to
bf5bdaf
Compare
Codecov Report
@@ Coverage Diff @@
## main #714 +/- ##
=======================================
Coverage 73.85% 73.85%
=======================================
Files 79 79
Lines 5970 5971 +1
=======================================
+ Hits 4409 4410 +1
Misses 1561 1561
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
michaeldeistler
approved these changes
Aug 10, 2022
add test use transform for DirectPosterior as default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #713
Before this PR, the
DirectPosteriorwas constructing atheta_transformfrom the prior support by default and used it for maybe calculating the MAP. This can cause issues if a custom prior has a funky support.This PR adds the
theta_transform = Noneargument to theDirectPosteriortop level so that users can pass anIdentityTransformto avoid the default construction of a transform to unconstrained space. If the argument is leftNonethe support of the prior is used to construct a transform -- as before.